Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove casting to int on increment ID which can be prefixed by a string #33369

Merged
merged 6 commits into from
Nov 21, 2021
Merged

Remove casting to int on increment ID which can be prefixed by a string #33369

merged 6 commits into from
Nov 21, 2021

Conversation

sippsolutions
Copy link
Member

@sippsolutions sippsolutions commented Jun 28, 2021 •
edited by m2-assistant bot
Loading

Description (*)

  • Remove casting to int on increment ID which can be prefixed by a string

Manual testing scenarios (*)

  1. Configure a string prefix to invoice increment IDs
  2. Submit an order
  3. Create an invoice
  4. Go to customer account -> orders -> invoice -> print invoice
  5. The increment ID should be there, but is "0" for numbers prefixed with a string

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove casting to int on increment ID which can be prefixed by a string #34451: Remove casting to int on increment ID which can be prefixed by a string

@m2-assistant
Copy link

m2-assistant bot commented Jun 28, 2021

Hi @sippsolutions. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 30, 2021

Thanks for contribute! Can you add some screenshot show problem?

ihor-sviziev
ihor-sviziev requested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sippsolutions,
Could you add escaping for the string, and cover it with some type of automated test?

@m2-community-project m2-community-project bot added this to Changes Requested in Pull Requests Dashboard Jun 30, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Progress: needs update labels Jun 30, 2021
@m2-community-project m2-community-project bot moved this from Changes Requested to On Hold in Pull Requests Dashboard Jun 30, 2021
@m2-community-project m2-community-project bot moved this from On Hold to Changes Requested in Pull Requests Dashboard Jun 30, 2021
sippsolutions and others added 2 commits August 27, 2021 17:18
@sippsolutions @ihor-sviziev
Add escaping to increment ID
8864695 
Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@sippsolutions
Merge branch '2.4-develop' into patch-2
bc62e48
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Aug 27, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Aug 27, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9208 has been created to process this Pull Request

@sivaschenko sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 19, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Oct 19, 2021
@engcom-Alfa engcom-Alfa self-assigned this Oct 27, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Oct 27, 2021
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 27, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Oct 27, 2021
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 27, 2021
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 27, 2021
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have a fresh Magento installation 2.4-develop

Manual testing scenario:

  1. Configure a string prefix to invoice increment IDs

  2. Place an order from front end

  3. Create invoice from admin

  4. Frontend: Go to customer account -> orders -> invoice -> print invoice

  5. Check the invoice number

Before: ✖️ Invoice ID used to be 0

image

After: ✔️ Invoice Id is printed correctly keeping prefix with string

image

Since it is a issue with a custom changes in the invoice related code, there is no additional testing or regression is required.

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Oct 27, 2021
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Oct 27, 2021
magento-engcom-team pushed a commit that referenced this pull request Nov 21, 2021
@sidolov
ENGCOM-9208: Remove casting to int on increment ID which can be prefi…
de8e62b 
…xed by a string #33369
@magento-engcom-team magento-engcom-team merged commit e7d048f into magento:2.4-develop Nov 21, 2021
@ihor-sviziev ihor-sviziev moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Sales Partner: TechDivision partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Risk: low Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Remove casting to int on increment ID which can be prefixed by a string
6 participants
@sippsolutions @mrtuvn @ihor-sviziev @magento-engcom-team @engcom-Alfa @sivaschenko